Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/127: fix the   character #159

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix/127: fix the   character #159

merged 1 commit into from
Sep 22, 2022

Conversation

Sidsector9
Copy link
Member

Description of the Change

The PR updates the react-character-map package to 0.4.8 which includes a fix for this issue.

Closes #127

How to test the Change

Please follow steps from the issue.

Changelog Entry

Fixed - Incorrectly rendered   character.

Credits

Props @redorca, @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested review from a team and ravinderk and removed request for a team September 11, 2022 15:41
@Sidsector9 Sidsector9 self-assigned this Sep 11, 2022
@Sidsector9 Sidsector9 added this to the 1.1.0 milestone Sep 11, 2022
@Sidsector9 Sidsector9 requested review from a team, ravinderk and iamdharmesh and removed request for ravinderk and a team September 11, 2022 15:43
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Sidsector9. LGTM 🚀

Before fix:
image


After fix:
image

@jeffpaul jeffpaul merged commit 68c2bea into develop Sep 22, 2022
@jeffpaul jeffpaul deleted the fix/127 branch September 22, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No-breaking spacing " " doesn't work
3 participants